• I added the following procedure to a job running every minute. This seems to work OK but I am quite new to this so I would welcome any suggestions for improvement.

    
    
    CREATE PROCEDURE procAddLogin AS
    DECLARE @UserId VARCHAR (7)
    DECLARE @Password VARCHAR (15)
    DECLARE NewUserCursor CURSOR FOR
    SELECT UserId, tmpPassword FROM SALES
    WHERE (tmpAdded = 0)

    OPEN NewUserCursor

    FETCH NEXT FROM NewUserCursor
    INTO @UserID, @Password

    WHILE @@FETCH_STATUS = 0
    BEGIN
    EXEC sp_addlogin @UserId, @Password
    EXEC sp_grantdbaccess @UserId
    EXEC sp_addrolemember 'kbuser', @userid
    UPDATE Sales SET
    tmpAdded = null,
    tmpPassword = null
    WHERE
    UserId = @UserId
    FETCH NEXT FROM NewUserCursor
    INTO @UserID, @Password
    END
    CLOSE NewUserCursor
    DEALLOCATE NewUserCursor
    GO